Add inputs_embeds support for .generate() with BLOOM models#21430
Merged
sgugger merged 1 commit intohuggingface:mainfrom Feb 3, 2023
akreal:generate_inputs_embeds_bloom
Merged
Add inputs_embeds support for .generate() with BLOOM models#21430sgugger merged 1 commit intohuggingface:mainfrom akreal:generate_inputs_embeds_bloom
inputs_embeds support for .generate() with BLOOM models#21430sgugger merged 1 commit intohuggingface:mainfrom
akreal:generate_inputs_embeds_bloom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
gante
approved these changes
Feb 3, 2023
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
Fantastic, thank you for adding it 👍
Contributor
|
There seems to be a CircleCI issue when triggering the tests 🤔 @akreal could you try following these instructions? I'm not sure whether they will help, but they were the closest match I found based on CircleCI's error message. |
sgugger
approved these changes
Feb 3, 2023
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds accepting
.generate()calls withinputs_embedson BLOOM models (following GPT2 example in #21405).Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@gante